feat: add coverart support #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoltzsche
force-pushed
the
add-coverart-support
branch
9 times, most recently
from
d2e77f5 to
cb53887
Compare
mgoltzsche
force-pushed
the
add-coverart-support
branch
from
cb53887 to
fa3b212
Compare
|
@Prior99 what's the state of this project? CI seems to be broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
get_imagesmethod within the LibraryProvider so that it returns image URLs for tracks and albums.The returned image URLs point to a new Mopidy endpoint
/subidy/coverart/{id}which forwards/reverse-proxies requests to the Subsonic server'sgetCoverArtendpoint. This is to authenticate with the Subsonic server, to avoid increasing configuration complexity and to support setups where the user cannot reach the Subsonic server directly.Tested against BinaryBrain/Beetstream#15